immich icon indicating copy to clipboard operation
immich copied to clipboard

Published 20 hours ago • verified publisher icon immich-app

feat(mobile): Add people list to exit bottom sheet

Open l0nax opened this issue 1 year ago • 2 comments

This PR adds a list of recognized people on the exif bottom sheet of an asset. This is similar to the feature already available on the web.

The changes are an MVP approach because the information is fetched from the server every time an asset is opened. In a future PR this can be changed to work offline as well.

https://github.com/immich-app/immich/assets/29659953/695736e6-2d3f-4465-8711-22c1c471506f

No connectivity to the server/ no internet:

https://github.com/immich-app/immich/assets/29659953/554233ef-9138-4ba6-8567-8ed44035f227

l0nax avatar Jan 29 '24 11:01 l0nax

Looks awesome!

jrasm91 avatar Jan 29 '24 12:01 jrasm91

@martyfuhry thanks for the comments. I've rebased the branch against the latest main and changed the imports.

l0nax avatar Feb 06 '24 17:02 l0nax

I rebased the branch against the upstream main and resolved the conflicts. The feature behaves and looks the same.

l0nax avatar Mar 05 '24 15:03 l0nax