immich icon indicating copy to clipboard operation
immich copied to clipboard

Published 20 hours ago • verified publisher icon immich-app

feat(server): Add size parameter to explore endpoint

Open boenni23 opened this issue 1 year ago • 5 comments

Fix for #6092. Adds a Places site for Web.

boenni23 avatar Jan 26 '24 19:01 boenni23

You also created a fix for this issue. But you missed the number of cities that are fetched from the database. So this is a additional commit for the new places page.

boenni23 avatar Jan 27 '24 06:01 boenni23

There has been a PR recently addresses this issue #6669

alextran1502 avatar Jan 27 '24 16:01 alextran1502

Yes and this PR did not include fetching more than 12 Places.

boenni23 avatar Jan 27 '24 18:01 boenni23

Sorry for the short answer. What I wanted to say is that api.searchApi.getExploreData() only takes 12 Places. So in order to show all places on this site you need to adjust the API too.

boenni23 avatar Jan 27 '24 18:01 boenni23

This PR is a little strange in that you call "explore" with -1 to get all the places. Explore is like a summary endpoint, and it seems better to have a dedicated endpoint to get a full list of places, potentially with pagination and other options, etc.

jrasm91 avatar Jan 27 '24 19:01 jrasm91

Closing, in favor of an implementation that uses the dedicated cities endpoint

jrasm91 avatar Apr 08 '24 20:04 jrasm91