immich icon indicating copy to clipboard operation
immich copied to clipboard

Change Date/Datetime - Bad Usabillity

Open MickLesk opened this issue 1 year ago • 10 comments

The bug

Hey!

I imported some photos from my Google Photos into Immich. Many photos have correct metadata, but some do not. You can see from my example that the photo originally comes from Whatsapp (%-WA%). It also has the correct location (not in all cases), but the wrong date. The import date is there.

If I change the date (to catalog everything correctly), I click on the pencil and enter the date. After the day is entered, the month appears, and when I enter the month, the day is set to "dd" again.

I have attached a video to visualize the topic.

https://github.com/immich-app/immich/assets/47820557/56c170e4-ad33-4e33-a447-8904d45dd3a3

The OS that Immich Server is running on

Docker (Debian 12 Bookworm - Proxmox)

Version of Immich Server

v.1.93.3

Version of Immich Mobile App

v.1.93.2 build.119

Platform with the issue

  • [X] Server
  • [X] Web
  • [ ] Mobile

Your docker-compose.yml content

version: "3.8"

#
# WARNING: Make sure to use the docker-compose.yml of the current release:
#
# https://github.com/immich-app/immich/releases/latest/download/docker-compose.yml
#
# The compose file on main may not be compatible with the latest release.
#

name: immich

services:
  immich-server:
    container_name: immich_server
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    command: [ "start.sh", "immich" ]
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - stack.env
    ports:
      - 2283:3001
    depends_on:
      - redis
      - database
    restart: always

  immich-microservices:
    container_name: immich_microservices
    image: ghcr.io/immich-app/immich-server:${IMMICH_VERSION:-release}
    # extends:
    #   file: hwaccel.yml
    #   service: hwaccel
    command: [ "start.sh", "microservices" ]
    volumes:
      - ${UPLOAD_LOCATION}:/usr/src/app/upload
      - /etc/localtime:/etc/localtime:ro
    env_file:
      - stack.env
    depends_on:
      - redis
      - database
    restart: always

  immich-machine-learning:
    container_name: immich_machine_learning
    image: ghcr.io/immich-app/immich-machine-learning:${IMMICH_VERSION:-release}
    volumes:
      - model-cache:/cache
    env_file:
      - stack.env
    restart: always

  redis:
    container_name: immich_redis
    image: redis:6.2-alpine@sha256:c5a607fb6e1bb15d32bbcf14db22787d19e428d59e31a5da67511b49bb0f1ccc
    restart: always

  database:
    container_name: immich_postgres
    image: tensorchord/pgvecto-rs:pg14-v0.1.11@sha256:0335a1a22f8c5dd1b697f14f079934f5152eaaa216c09b61e293be285491f8ee
    env_file:
      - stack.env
    environment:
      POSTGRES_PASSWORD: ${DB_PASSWORD}
      POSTGRES_USER: ${DB_USERNAME}
      POSTGRES_DB: ${DB_DATABASE_NAME}
    volumes:
      - pgdata:/var/lib/postgresql/data
    restart: always

volumes:
  pgdata:
  model-cache:

Your .env content

UPLOAD_LOCATION=./library
IMMICH_VERSION=release
DB_PASSWORD=postgres
DB_HOSTNAME=immich_postgres
DB_USERNAME=postgres
DB_DATABASE_NAME=immich
REDIS_HOSTNAME=immich_redis

Reproduction steps

0. Show Video :D
1. Open Photo
2. Click Edit Button
3. Enter Date/Time
...

Additional information

No response

MickLesk avatar Jan 24 '24 08:01 MickLesk

Can confirm, the zero key causes problems.

waclaw66 avatar Jan 24 '24 09:01 waclaw66

ah yes, youre right. the "zero" causes the problem. ive testing without zero, that works.

MickLesk avatar Jan 24 '24 10:01 MickLesk

ah yes, youre right. the "zero" causes the problem. ive testing without zero, that works.

I tried to reproduce the problem with Google Chrome, I can enter the value without problem. What browser are you using?

image

aviv926 avatar Jan 27 '24 20:01 aviv926

I tried to reproduce the problem with Google Chrome, I can enter the value without problem. What browser are you using?

Firefox

waclaw66 avatar Jan 27 '24 20:01 waclaw66

ah yes, youre right. the "zero" causes the problem. ive testing without zero, that works.

I tried to reproduce the problem with Google Chrome, I can enter the value without problem. What browser are you using?

image

Newest Chrome. German language & german Datetime. Firefox too, Edge too

MickLesk avatar Jan 27 '24 20:01 MickLesk

image

For me there is no pencil to change dates? [v1.93.3] at Chrome

DeltaTango69 avatar Jan 31 '24 14:01 DeltaTango69

image

For me there is no pencil to change dates? [v1.93.3] at Chrome

it's ok, because it is loaded from an external library with read only permissions.

aviv926 avatar Jan 31 '24 15:01 aviv926

Ok, this make sense - thank you!

DeltaTango69 avatar Jan 31 '24 15:01 DeltaTango69

ah yes, youre right. the "zero" causes the problem. ive testing without zero, that works.

I tried to reproduce the problem with Google Chrome, I can enter the value without problem. What browser are you using?

image

Newest Chrome. German language & german Datetime. Firefox too, Edge too

Can you change the language temporarily to see if the problem still exists?

aviv926 avatar Jan 31 '24 15:01 aviv926

English is okay (for my problem above), there is another Bug, you can have 6 numbers for year :-D i think thats for the last 2 --

image

MickLesk avatar Feb 02 '24 10:02 MickLesk