immich icon indicating copy to clipboard operation
immich copied to clipboard

feat(web): add keyboard shortcut to stack selected photos

Open Funk66 opened this issue 1 year ago • 4 comments

This is my attempt at implementing https://github.com/immich-app/immich/discussions/5143 I should say that I have zero experience with Svelte. I would be nice to reduce the duplication with https://github.com/immich-app/immich/blob/3edc87f6840a96b04e318f1f1d823c81e642bc20/web/src/lib/components/photos-page/actions/stack-action.svelte#L15 but I'm not familiar with the import hierarchy and event propagation conventions, so I would appreciate some guidance here. As a side note, it may seem confusing to some that the help dialog shows action shortcuts that only work in the asset-viewer page, and now this new one that only works in the asset-grid page. Perhaps these should be shown under different categories.

Funk66 avatar Dec 26 '23 10:12 Funk66

When can this get merged?

ThomasConrad avatar Jan 10 '24 10:01 ThomasConrad

The logic to stack assets already exist in https://github.com/immich-app/immich/blob/main/web/src/lib/components/photos-page/actions/stack-action.svelte.

Can you use the same logic for the menu option and the shortcut action ?

martabal avatar Jan 10 '24 11:01 martabal

I tried deduplicating the code, but I don't know if my changes follow best practices.

Funk66 avatar Jan 13 '24 20:01 Funk66

This would be so handy! How close is a merge?

flightmansam avatar Jan 25 '24 02:01 flightmansam

Any chance this can get merged? It would be crazy helpful!!

isaacolsen94 avatar Mar 29 '24 00:03 isaacolsen94

@Funk66 can you resolve the merge conflicts and then we can look at merging it.

jrasm91 avatar Mar 29 '24 03:03 jrasm91

Thank you so much @funk66, @jrasm91 is this good to go now? Sorry to pester! Just could really use this 😛

isaacolsen94 avatar Mar 30 '24 16:03 isaacolsen94