immich icon indicating copy to clipboard operation
immich copied to clipboard

Published 20 hours ago • verified publisher icon immich-app

fix(mobile): fix forgetting backup albums (#3108)

Open madadam opened this issue 2 years ago • 3 comments
trafficstars

Fix/workaround for #3108. It seems the bug is caused by a weird behaviour / bug in photo_manager: Sometimes AssetPathEntity.fromId throws even when called with a valid asset id (say one returned from a previous call to PhotoManager.getAssetPathList).

This PR works around that by looking the assets up in a previously obtained map instead of calling AssetPathEntity.fromId.

How has this been tested

Manually, by deploying the patched app to my phone with flutter run and then going through the repro steps.

madadam avatar Jul 13 '23 20:07 madadam

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Jul 13, 2023 8:24pm

vercel[bot] avatar Jul 13 '23 20:07 vercel[bot]

Can you add a few lines to the PR description on how this change has been tested

alextran1502 avatar Jul 13 '23 21:07 alextran1502

Can you add a few lines to the PR description on how this change has been tested

Added. Is it sufficient?

madadam avatar Jul 14 '23 16:07 madadam