immich icon indicating copy to clipboard operation
immich copied to clipboard

[BUG] Map shows some pictures on Null Island

Open cfpwastaken opened this issue 1 year ago • 5 comments

The bug

Some photos in my library have location data for Null Island. It is the exact center point of the map. image Pictures can have location data of 0 longitude, 0 latitude when the data gets stripped out or something went wrong trying to get the location when taking the picture.

The OS that Immich Server is running on

Alpine Linux, but it is dockerized, another image creator

Version of Immich Server

v1.64.0

Version of Immich Mobile App

v1.64.0 build.87

Platform with the issue

  • [ ] Server
  • [X] Web
  • [X] Mobile

Your docker-compose.yml content

version: "3"
services:
  immich:
    image: ghcr.io/imagegenius/immich:latest
    container_name: immich
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/Berlin
      - DB_HOSTNAME=postgres
      - DB_USERNAME=postgres
      - DB_PASSWORD=postgres
      - DB_DATABASE_NAME=immich
      - REDIS_HOSTNAME=redis
      #- DISABLE_MACHINE_LEARNING=false
      #- DISABLE_TYPESENSE=false
      - DB_PORT=5432 #optional
      - REDIS_PORT=6379 #optional
      - REDIS_PASSWORD= #optional
      - CUDA_ACCELERATION=false #optional
    volumes:
      - ./config:/config
      - ./photos:/photos
      - ./ml:/config/machine-learning #optional
    ports:
      - 1034:8080
    restart: unless-stopped
  redis:
    image: redis
    ports:
      - 6379:6379
    container_name: redis
  postgres:
    image: postgres:14
    ports:
      - 5432:5432
    container_name: postgres14
    environment:
      POSTGRES_USER: postgres
      POSTGRES_PASSWORD: postgres
      POSTGRES_DB: immich
    volumes:
      - postgres:/var/lib/postgresql/data

volumes:
   postgres:

Your .env content

I put the environment vars in the docker compose file

Reproduction steps

1. Obtain a photo with Null Island location info
2. View the "Map" tab in Immich
3. See the issue in the middle of the map

Additional information

Immich should detect that 0,0 location data and just not show those photos on the Map.

cfpwastaken avatar Jun 27 '23 19:06 cfpwastaken

So you are expected to not show assets that have lat/long = 0,0?

alextran1502 avatar Jun 27 '23 19:06 alextran1502

The only content I have right now I'd rather not share, Ill see if I find another example

cfpwastaken avatar Jun 27 '23 19:06 cfpwastaken

The only content I have right now I'd rather not share, Ill see if I find another example

No, I mean if assets have lat/lon at Null island, then you expect they are not shown on the map, correct?

alextran1502 avatar Jun 27 '23 19:06 alextran1502

oh, yes I do. They should be hidden on the map.

cfpwastaken avatar Jun 27 '23 19:06 cfpwastaken

Got it, thank you

alextran1502 avatar Jun 27 '23 19:06 alextran1502

I believe that there should be an option as to whether they are shown on the map or not.

Currently not all of my images are showing up on the map (Still processing all the machine learning), and it is useful for debugging purposes to know if they are missing or at null island? But default should be to not show, with the option to show hidden inside the "Map Settings".

GrMoney93 avatar Aug 12 '23 09:08 GrMoney93

I suppose this makes sense.

cfpwastaken avatar Aug 12 '23 13:08 cfpwastaken