immich icon indicating copy to clipboard operation
immich copied to clipboard

[UI] Multiple issues with Location filtering in Search

Open null-von-sushi opened this issue 1 year ago • 0 comments

The bug

The issues

  1. When searching, the option to search by Country, State and and City is available. I am assuming this was designed to be USA-centric and follows America's definition of State, however it can be rather confusing elsewhere in the world. It almost looks like it means county, prefecture or province elsewhere as I get Taiwan and Kyoto in there as well, however it then stops making sense because it also shows Wales and England which are not provinces, states or anything else else, they are just countries. As for Taiwan, while Taiwan is officially a Province of the Republic of China, Taipei is not a province (assuming State should mean province or prefecture for Asian countries?).

  2. Additionally, Taiwan (officially the Republic of China, not to be confused with the People's Republic of China) is erroneously listed as 'Taiwan, Province of China' under 'Countries´. This is ambiguous at best but is more likely to come across as politically insensitive and insulting. I assume the currently phrasing is just the result of using a UN list of countries which unfortunately is not accurate due to political pressure from China. Feel free to look up the situation yourself, but the tl;dr is it's kinda like North and South Korea.).

Proposed solutions

Regarding point 1, I am genuinely not sure how to fix it as the issue is basically that different countries are split up differently, and that 1-size-fits-all does not work. I recommend only showing state if the country actually has useful subdivisions, and if so I would have the field 'State' renamed depending on the country. I.e. USA shows state. I assume it works as intended for you. If Selecting United Kingdom, it seems to show the other countries that make up the UK, so I would show state but have it labelled 'Specific country' or something like that. For Japan show it but have the label 'Prefecture'. etc. Or just call it 'Region' for all countries. Technically that's ambiguous and would fit all countries I believe.

For point 2, the country listing should be updated to either be Taiwan or Republic of China (Taiwan) Taiwan (ROC), depending on how formal you want it to be. IF you call the USA 'America', then just having 'Taiwan' would be fine. If you have it listed as 'United States of America', I would recommend one of the two latter options. Personally I would have it as Taiwan (ROC) as would help people who are searching the list for a word starting with 'T'.

The OS that Immich Server is running on

TrueNAS

Version of Immich Server

v1.107.2

Version of Immich Mobile App

N/A

Platform with the issue

  • [X] Server
  • [X] Web
  • [ ] Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

0. Ensure your immich instance has photos with exif data from outside the USA (such as Wales, England, Japan), as well as one from Taiwan.
1. Open the website of your immich instance
2. Click the settings icon next to the searchbar
3. Observe the mismatch between location name and the label 'State' when looking through the different options in 'State'.
4. Observe the issue in the name of Taiwan when looking at the list of countries.

Relevant log output

No response

Additional information

No response

null-von-sushi avatar Jul 10 '24 10:07 null-von-sushi