lighting-estimation icon indicating copy to clipboard operation
lighting-estimation copied to clipboard

Consider exposing the XRReflectionProbe off the XRSession object

Open kearwood opened this issue 5 years ago • 3 comments

As the XRReflectionProbe's cube map can likely be used for multiple frames and is not updated every frame, perhaps it should be exposed on the XRSession object rather than XRFrame. It should also have an event to indicate when a new cube map is available.

The WebGL rendering engine could then interpolate between the last and new cube map when a new one is available.

kearwood avatar Feb 05 '20 19:02 kearwood

Given that it could be updated at most every frame, wouldn't it make sense to have it hanging on XRFrame and make sure the developer is aware/can figure out if the frame has changed?

mounirlamouri avatar Feb 05 '20 20:02 mounirlamouri

I agree, I would think it would be in the frame. During the discussion of hit test, and real world geometry, we talked about having a single data structure for "real world info" that any information about the world (hit tests, geometry, illumination, and so on) would be part of (to avoid littering the frame object with extra fields as features are added).

blairmacintyre avatar Feb 05 '20 20:02 blairmacintyre

During the discussion of hit test, and real world geometry, we talked about having a single data structure for "real world info" that any information about the world (hit tests, geometry, illumination, and so on) would be part of (to avoid littering the frame object with extra fields as features are added).

I think the proposal in this repo doesn't use that object. Piotr's proposal that we have behind a flag in Chrome is this though. In general, we are fine either way. It would be nice to have one object holding things but also would create cyclical dependencies between specs for something fairly minor.

mounirlamouri avatar Feb 06 '20 21:02 mounirlamouri