depth-sensing icon indicating copy to clipboard operation
depth-sensing copied to clipboard

Add support for texture arrays

Open cabanier opened this issue 2 years ago • 7 comments


Preview | Diff

cabanier avatar Oct 06 '23 04:10 cabanier

@bialpio what do you think?

cabanier avatar Oct 06 '23 20:10 cabanier

Any update on this PR?

RaananW avatar Dec 18 '23 20:12 RaananW

Any update on this PR?

@toji ?

cabanier avatar Dec 18 '23 20:12 cabanier

Pinging @bialpio on the question I asked previously: Does the Android depth sensing use the GPU accelerated path at all?

If not, I'm inclined to say that the GL_TEXTURE_2D path should be dropped prior to merging.

toji avatar Jan 02 '24 21:01 toji

Pinging @bialpio on the question I asked previously: Does the Android depth sensing use the GPU accelerated path at all?

Ah, sorry, missed the in-review comment. No, we do not support the GPU-accelerated path for our ARCore-backed implementation on Android.

bialpio avatar Jan 02 '24 21:01 bialpio

Pinging @bialpio on the question I asked previously: Does the Android depth sensing use the GPU accelerated path at all?

Ah, sorry, missed the in-review comment. No, we do not support the GPU-accelerated path for our ARCore-backed implementation on Android.

Could we update the sample so it works on Android as well? Maybe by uploading the depth to a texture?

cabanier avatar Jan 02 '24 21:01 cabanier

Pinging @bialpio on the question I asked previously: Does the Android depth sensing use the GPU accelerated path at all?

Ah, sorry, missed the in-review comment. No, we do not support the GPU-accelerated path for our ARCore-backed implementation on Android.

Could we update the sample so it works on Android as well? Maybe by uploading the depth to a texture?

Let me look into that, I think the public sample may not have the changes that happened in our internal, for-testing sample.

bialpio avatar Jan 02 '24 21:01 bialpio