immer
immer copied to clipboard
immerjs
Proposed fix for #819
As pointed out in #819 insertion order is not always preserved when adding to a Set, though according to MDN it should be.
We were already cloning and iterating over the cloned Set anyway in finalize.
If we take it a step further to clear the original Set after cloning and let finalizeProperty know it needs to re-add non-draftable children back to the target then we end up rebuilding the Set in it's original order.
We then no longer need to delete anything from the Set in set
Deploy Preview for quizzical-lovelace-dcbd6a canceled.
| Name | Link |
|---|---|
| Latest commit | ab864a675d1f4045411df0ba2bb8f21444a37d0b |
| Latest deploy log | https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/631a8c5ad5760200091410bc |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Sorry for the late follow up! Changes look legit, will include in the next minor.
:tada: This PR is included in version 9.0.18 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Sorry for the late follow up! Changes look legit, will include in the next minor.
No worries. Thanks for taking the time to review/include it!