go-libav icon indicating copy to clipboard operation
go-libav copied to clipboard

remove "deprecated-declarations" warnings

Open juanvallejo opened this issue 7 years ago • 4 comments

Before

$ go build examples/transcoder.go
# github.com/imkira/go-libav/avcodec
avcodec/avcodec.go: In function ‘_cgo_a038601aec5c_Cfunc_av_bitstream_filter_close’:
avcodec/avcodec.go:162:2: warning: ‘av_bitstream_filter_close’ is deprecated [-Wdeprecated-declarations]
  FlagLowDelay      Flags = C.CODEC_FLAG_LOW_DELAY
  ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from avcodec/avcodec.go:4:0:
/usr/include/ffmpeg/libavcodec/avcodec.h:5836:6: note: declared here
 void av_bitstream_filter_close(AVBitStreamFilterContext *bsf);
      ^~~~~~~~~~~~~~~~~~~~~~~~~

...

After

$ go build examples/transcoder.go
$

juanvallejo avatar Jun 27 '17 19:06 juanvallejo

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   33.72%   33.72%           
=======================================
  Files           5        5           
  Lines        2583     2583           
=======================================
  Hits          871      871           
  Misses       1664     1664           
  Partials       48       48
Impacted Files Coverage Δ
avutil/avutil.go 32.91% <ø> (ø) :arrow_up:
avcodec/avcodec.go 22.7% <ø> (ø) :arrow_up:
avfilter/avfilter.go 24.83% <ø> (ø) :arrow_up:
avformat/avformat.go 56.19% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52e4012...cb08b32. Read the comment docs.

codecov-io avatar Jun 27 '17 19:06 codecov-io

@juanvallejo Hi there. Thanks for the contribution. I was thinking, maybe it would be better to get rid of the deprecation itself, rather than just disabling the warning.

imkira avatar Jun 29 '17 02:06 imkira

@imkira sure, will work on this once I have a bit of time

juanvallejo avatar Jun 29 '17 14:06 juanvallejo

Thanks @juanvallejo . Please let us know too which version of ffmpeg are you using.

imkira avatar Jun 30 '17 02:06 imkira