go-libav icon indicating copy to clipboard operation
go-libav copied to clipboard

add motion vector extraction from side data

Open cvley opened this issue 7 years ago β€’ 6 comments

Hi, I need motion vector extraction from video, so I implement related functions.

Pls. review them, thanks πŸ˜„

cvley avatar Mar 24 '17 10:03 cvley

Codecov Report

Merging #33 into master will decrease coverage by 0.32%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   32.11%   31.79%   -0.33%     
==========================================
  Files           4        4              
  Lines        2525     2551      +26     
==========================================
  Hits          811      811              
- Misses       1667     1693      +26     
  Partials       47       47
Impacted Files Coverage Ξ”
avutil/avutil.go 31.75% <0%> (-1.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update a36251d...496bfea. Read the comment docs.

codecov-io avatar Mar 24 '17 10:03 codecov-io

@cvley Thank you for your PR. Please take a look at the review. Can you also add some simple tests where you call all new functions? Thanks

imkira avatar Mar 26 '17 12:03 imkira

@imkira Thanks for your reviews. I will work on it πŸ˜„

cvley avatar Mar 26 '17 13:03 cvley

@imkira I have fixed the code and add a simple test, please review them.

By the way, I'd like to generate a random video in the test to perform motion vectors extraction, is it OK?

Thanks.

cvley avatar Mar 27 '17 23:03 cvley

@cvley No problem about the random video.

During tests I'm currently downloading to a directory called fixtures

https://bintray.com/imkira/go-libav/download_file?file_path=sample_iPod.m4v https://bintray.com/imkira/go-libav/download_file?file_path=sample_iTunes.mov https://bintray.com/imkira/go-libav/download_file?file_path=sample_mpeg4.mp4

And referencing them like this: https://github.com/imkira/go-libav/blob/126f4da001527349ba3f1c933fdb4e8eb6923698/avformat/avformat_test.go#L60

Do any of these work for your tests?

If not, please send me the file to [email protected] and I will upload it for the tests. Thanks

imkira avatar Mar 28 '17 13:03 imkira

Any update on this @cvley ?

imkira avatar Jun 30 '17 02:06 imkira