ok-to-test icon indicating copy to clipboard operation
ok-to-test copied to clipboard

See explicit logs in original workflow run

Open Wxl19980214 opened this issue 2 years ago • 7 comments

@imjohnbo hello, we have applied your template in our repo, yet there is some functionality we want cannot be achieved. So we would like to hear some insights from you. So basically we would like to see the logs in the original workflow instead of the /ok-to-test command workflow for a forked-based pull request. For example, if you look here It says the check is skipped. Let's say the owner triggered the /ok-to-test workflow and it fails, here it will only display the check fails. The real logs are displayed in the newly triggered /ok-to-test workflow. So what we want is that right here in the original workflow we can see the error log, or at least can display an url pointing to the actual running workflow. Do you think this is achievable? Thanks

Wxl19980214 avatar Jun 17 '22 17:06 Wxl19980214

👋 Hi @Wxl19980214, your workflow configuration should make job logs appear in your Linux-integration-forked check run if these conditions are met. I think in your case, that job (which translates to a check run) is skipped because you didn't yet comment /ok-to-test sha=blahblah in your PR.

Let me know if that makes sense 🙇.

imjohnbo avatar Jun 23 '22 23:06 imjohnbo

Hi @imjohnbo, I am sorry we forgot to comment /ok-to-test. If you take a look at this PR(https://github.com/ploomber/ploomber/pull/866) , you will see tests such as Integration tests / Windows-integration-forked (pull_request), and if you click detail, it is marked as cancelled. But the /ok-to-test command has triggered a new workflow here and it is failing. What we want is that the log information in the failed workflow can be somehow passed into the original one. So when we click on details in the PR, we see the log error. Do you think this is achievable? Thanks a lot! : )

Wxl19980214 avatar Jun 27 '22 16:06 Wxl19980214

Would you mind starting fresh from an up to date fork? I think some wires are getting crossed between your old style of ci-integration.yml, PR'd from your fork, and the new style of ci-integration-PLATFORM.yml, introduced after your fork was made. 🙏

imjohnbo avatar Jun 28 '22 01:06 imjohnbo

Yes. I have recreate the scenario: here is the PR (https://github.com/ploomber/ploomber/pull/887) and you will see it fails on all forked integration tests like this: MacOS integration tests / Macos-integration-forked (pull_request) . But if you click on the details here it only tells me this check failed. The actual log is in a new workflow here. We would like to somehow be able to see the logs in the original workflow, is this something achievable? Thanks!

Wxl19980214 avatar Jun 29 '22 17:06 Wxl19980214

I see now, thanks for reproducing. Yeah, it'd be nice to associate this grouping (check suite or check run or workflow run? I've lost the thread after a couple of years) with the PR. I thought it might be a complication with matrix builds, but I reproduced it with one environment builds too.

I'm going to consider this an https://github.com/imjohnbo/ok-to-test/labels/enhancement since the core functionality of using secrets in actions from forked PRs works. As a workaround, we're still able to navigate to the overview like this through the Actions logs.

Contributions and ideas welcome!

imjohnbo avatar Jun 30 '22 13:06 imjohnbo

Thank you anyway. I have tried multiple ways. But looks like only part of information can be passed on to the original flow! Thanks for the template, it's very useful.

Wxl19980214 avatar Jun 30 '22 14:06 Wxl19980214

Beep boop! 🤖 This issue hasn't had any activity in a while. I'll close it if I don't hear back soon.

github-actions[bot] avatar Aug 04 '22 17:08 github-actions[bot]