imgui-rs
imgui-rs copied to clipboard
0.8.1 docs build failing
https://docs.rs/crate/imgui/0.8.1/builds/482032
[INFO] [stderr] error: Package `imgui v0.8.1 (/opt/rustwide/workdir)` does not have the feature `docking`
Took me a while to realize why: 0.8 doesn't have the docking feature (that will be part of 0.9)
Shit! Looks like we're going to 0.8.2
Does anyone know of a way we could have prevented this in CI in the future?
0.8.2 fails docs build for different reason :cry:
I think I need to update the exclude = ["third-party/*.json", "third-party/*.lua", "third-party/imgui/*/"]
in imgui-sys/Cargo.toml
as it's now wrong with the copypaste imgui setup (unrelated to the docs.rs build problem), but also breaking the docs-build by excluding misc/imgui_freetype.cpp
etc
..although I suspect it may keep failing once this is fixed unless docs.rs has the freetype package installed (which is done globally as per https://github.com/rust-lang/docs.rs/issues/630 ) - edit: nope, the required packages seem to be installed
let me know when we're good to go for gucci 0.8.3?
Does anyone know of a way we could have prevented this in CI in the future?
It wouldn't help with the initial problem (missing docking
feature), but we should probably have a CI step which uses cargo package
to test the packaging for crates.io is working (which would catch the missing misc/imgui_freetype.cpp
problem)
Not sure about the initial problem - posted here about it
@sanbox-irl Done in PR #595