imgproxy-helm icon indicating copy to clipboard operation
imgproxy-helm copied to clipboard

feat: Add custom settings for pod- and containerSecurityContext instead of global securityContext

Open kaufmo opened this issue 7 months ago • 3 comments

this one was merged in a custom branch and never got it into master so new try (https://github.com/imgproxy/imgproxy-helm/pull/157)

kaufmo avatar May 15 '25 12:05 kaufmo

definitely needed 👍

vr avatar May 15 '25 13:05 vr

@DarthSim @dragonsmith can somebody pls take a look here?

kaufmo avatar May 28 '25 10:05 kaufmo

Hey @kaufmo! Please don't rename values. This will break things for everyone who uses them.

DarthSim avatar May 28 '25 10:05 DarthSim

As Darthsim mentioned above, though, this approach would break backward compatibility. There’s also #201, which addresses the issue in the same way but without renaming. I appreciate your contribution! At this point, I think the other PR should take precedence. Thank you again for your efforts here.

gzigzigzeo avatar Sep 24 '25 15:09 gzigzigzeo

However, naming here is much more logical

gzigzigzeo avatar Sep 24 '25 15:09 gzigzigzeo

Thank you again for implementing this. I've merged #198, and fixed the naming as you proposed here, with deprecation warning for an old value. Closing this for now.

gzigzigzeo avatar Sep 25 '25 10:09 gzigzigzeo