imgproxy-helm icon indicating copy to clipboard operation
imgproxy-helm copied to clipboard

refactor: use image.repository instead of abbreviation

Open kaufmo opened this issue 6 months ago • 2 comments
trafficstars

tools like renovate can update the combination of repository & tag

see here for more details

kaufmo avatar May 15 '25 12:05 kaufmo

@DarthSim @dragonsmith can somebody pls take a look here?

kaufmo avatar May 28 '25 10:05 kaufmo

Hey @kaufmo! I don't think that's a good idea. This change will break things for all our Pro users and those who deploy imgproxy from some custom repos.

DarthSim avatar May 28 '25 10:05 DarthSim

Unfortunately, this change will break backward compatibility. I guess, you can configure renovatebot to look for the image.repo key in the imgproxy values. Bot's helm-values manager should have this feature, if I am not mistaken.

gzigzigzeo avatar Sep 24 '25 14:09 gzigzigzeo

On the other hand, repository is the standard key name. Let me close this for now since even if we decide to change this, it would involve introducing an alias, helper, deprecation warning, etc. I'll circle back to this issue later today.

gzigzigzeo avatar Sep 25 '25 10:09 gzigzigzeo