background-removal-js icon indicating copy to clipboard operation
background-removal-js copied to clipboard

fix: Change lodash to lodash.memoize

Open vanling opened this issue 1 year ago • 2 comments

fix: https://github.com/imgly/background-removal-js/issues/78

I still had a problem with loading the node lib on Nuxt3 (server) I believe this is the way to fix that issue where the dependency could not be found.

My knowledge of npm with multiple packages like this is minimal, so I hope i did this right

vanling avatar May 11 '24 11:05 vanling

Maybe this only happened when i tried to use the web version. ( I might close this soon)

Update: ok, so this missing memoize/lodash only happened when using the browser version in nuxt, the node version worked. ( i think i messed up by switching in between.)

Leaving this open to hear your thoughts, might stil be a good change to only import the memoize function instead of the whole lib

vanling avatar May 11 '24 11:05 vanling

Is it still a problem in 1.5 that was released last week? The issue you are referring to was already solved before. It might be a regression though.

DanielHauschildt avatar May 13 '24 11:05 DanielHauschildt

So it happened only with the 'browser version', node version works ok in Nuxt/server. I will take another look tomorrow with the browser version in Nuxt/frontend.

vanling avatar May 16 '24 08:05 vanling

@DanielHauschildt closing, can not reproduce on browser or server. I guess I mixed up node and browser version the last time.

vanling avatar May 17 '24 11:05 vanling