vue icon indicating copy to clipboard operation
vue copied to clipboard

build: add type declarations to /dist #517

Open namack opened this issue 8 months ago • 3 comments

Closes #517

Description

This change includes the type declaration file in /dist.

Before this PR, typescript users did not have automatic type inference.

After this PR, typescript users will have automatic type inference.

Checklist

  • [x] Read the contributing guidelines.
  • [x] Each commit follows the Conventional Commit spec format.
  • [x] All existing unit tests are still passing (if applicable).

namack avatar Dec 14 '23 19:12 namack

@luqven One thing I was unsure of was including the /dist/imgix-vue.min.d.ts file in the git history to be included in the release for distribution. I didn't see any un-ignoring of the current build files in /dist in .gitignore, however I am not familiar with this distribution method.

namack avatar Dec 14 '23 19:12 namack

@luqven One thing I was unsure of was including the /dist/imgix-vue.min.d.ts file in the git history to be included in the release for distribution. I didn't see any un-ignoring of the current build files in /dist in .gitignore, however I am not familiar with this distribution method.

Semantic-Release should commit that to /dist for us ✅

luqven avatar Dec 14 '23 23:12 luqven

Ah great, that's what I was hoping for. Let me know if there's anything else I can do to get this over the line. Looks like CI ran into an issue with the github auth token.

namack avatar Dec 15 '23 16:12 namack