imgix-rails icon indicating copy to clipboard operation
imgix-rails copied to clipboard

fix: fix issue where breakpoint srcset_options weren't being used

Open Talljoe opened this issue 1 year ago • 1 comments

Description

When setting srcset_options on a breakpoint it was not being used by Tag::srcset instead defaulting to the generic srcset_options (if provided). This change makes srcset used the options passed to the method instead of the class-instance variables.

Checklist

  • [x] Read the contributing guidelines.
  • [x] Each commit follows the Conventional Commit spec format.
  • [x] Update the readme (if applicable).
  • [x] Update or add any necessary API documentation (if applicable)
  • [x] All existing unit tests are still passing (if applicable).
  • [x] Add some steps so we can test your bug fix or feature (if applicable).
  • [x] Add new passing unit tests to cover the code introduced by your PR (if applicable).
  • [x] Any breaking changes are specified on the commit on which they are introduced with BREAKING CHANGE in the body of the commit.
  • [x] If this is a big feature with breaking changes, consider opening an issue to discuss first. This is completely up to you, but please keep in mind that your PR might not be accepted.

Talljoe avatar Aug 25 '23 00:08 Talljoe

Bug Fixes

  • fix issue where breakpoit srcset_options weren't being used (5a446af)

Contributors

Talljoe

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

commit-lint[bot] avatar Aug 25 '23 00:08 commit-lint[bot]