imgix-php icon indicating copy to clipboard operation
imgix-php copied to clipboard

Return the url and avoid the temp variable

Open shakaran opened this issue 7 years ago • 2 comments

Since no checks of array values with isset or so and just normal concatenation

shakaran avatar Sep 05 '17 15:09 shakaran

Hey there 👋 This PR was closed inadvertently because we renamed our default branch from master to main in order to progress towards removing oppressive terminology from our repositories. Unfortunately, this had the unintended consequence of closing this PR. I've remedied this by changing the base of this PR.

frederickfogerty avatar Jun 25 '20 23:06 frederickfogerty

@frederickfogerty ok, so ready to merge 3 years later?

shakaran avatar Jun 26 '20 21:06 shakaran

Contributors

shakaran

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

commit-lint[bot] avatar Aug 25 '22 12:08 commit-lint[bot]

LGTM @shakaran do you mind adjusting the commit and PR title to adhere to the conventional commit standard? After that, I'll be happy to merge this in.

refactor: return the URL and avoid the temp variable

✓ Done

shakaran avatar Aug 30 '22 14:08 shakaran

Congrats @shakaran, this has got to be some kind of record 😂

sherwinski avatar Aug 30 '22 19:08 sherwinski