imgix-php
imgix-php copied to clipboard
Return the url and avoid the temp variable
Since no checks of array values with isset or so and just normal concatenation
Hey there 👋 This PR was closed inadvertently because we renamed our default branch from master to main in order to progress towards removing oppressive terminology from our repositories. Unfortunately, this had the unintended consequence of closing this PR. I've remedied this by changing the base of this PR.
@frederickfogerty ok, so ready to merge 3 years later?
Contributors
Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR:
-
@Commit-Lint merge patch
will merge dependabot PR on "patch" versions (X.X.Y - Y change) -
@Commit-Lint merge minor
will merge dependabot PR on "minor" versions (X.Y.Y - Y change) -
@Commit-Lint merge major
will merge dependabot PR on "major" versions (Y.Y.Y - Y change) -
@Commit-Lint merge disable
will desactivate merge dependabot PR -
@Commit-Lint review
will approve dependabot PR -
@Commit-Lint stop review
will stop approve dependabot PR
LGTM @shakaran do you mind adjusting the commit and PR title to adhere to the conventional commit standard? After that, I'll be happy to merge this in.
refactor: return the URL and avoid the temp variable
✓ Done
Congrats @shakaran, this has got to be some kind of record 😂