Imgbot icon indicating copy to clipboard operation
Imgbot copied to clipboard

Published 20 hours ago • verified publisher icon imgbot

Uses wrong units.

Open K0-RR opened this issue 3 years ago • 3 comments

Example Imgbot PR - https://github.com/RDKRACZ/BasicNetherOres/pull/2 Inside the details section, columns before and after use kilobits (kb) whereas the size value is in fact in kilobytes (kB). Also, theoretically, the unit in use should be Kibibyte, not Kilobyte.

K0-RR avatar Nov 22 '21 22:11 K0-RR

KiB, MiB etc would be precise, so multi-byte units notation.

MichaIng avatar Nov 24 '21 13:11 MichaIng

Hello there, I would like to add this functionality. Could someone add me as participant?

lnsandnkth avatar Apr 11 '22 08:04 lnsandnkth

That would be great. I suggest you fork the project, apply the changes to your fork, then open a pull request with your changes here.

I'm not sure whether contributors are added to the orga or as formal collaborators here at all, but definitely not because of a post in a random open issue and more likely after a successful contribution via pull request 🙂.

MichaIng avatar Apr 11 '22 13:04 MichaIng