mac-precision-touchpad icon indicating copy to clipboard operation
mac-precision-touchpad copied to clipboard

Magic Trackpad 2 too sensitive (1mm from surface)

Open tyger opened this issue 6 years ago • 26 comments

Pre-report checks

  • [x] Have you checked (use search) Azure DevOps Board and Github issues for known bugs and plans?

Describe the bug Trackpad reacts on my finger that is in 1-2mm distance from trackpad surface. So basically I can move cursor not touching trackpad at all. Feels like it's too much sensitive (no such behaviour with this trackpad when connected to MacBook)

To Reproduce Steps to reproduce the behavior:

  1. Connect device to Windows laptop and intall driver
  2. Try to move finger within 1-2mm from surface.

Expected behavior Trackpad should react on the finger only and when it is touching surface of trackpad.

Traces If applicable, add WPP traces to help explain your problem. ????

Environment Apple Magic Trackpad 2 (Model A1535) connected to USB to Lenovo X1 Extreme Windows 10 v1903

driver type is USB type (User-mode)

AB#680

tyger avatar Nov 01 '19 22:11 tyger

Currently the threshold is hard-coded, a tool for the adjustment is planned.

Also relate to #239.

imbushuo avatar Nov 07 '19 19:11 imbushuo

@imbushuo What is your idea about making it adjustable? Will it be easier to just put something into Windows Registry? That should save some time creating tools.

tyger avatar Nov 08 '19 22:11 tyger

Have thought of that. Probably need to do some application work.

imbushuo avatar Nov 11 '19 20:11 imbushuo

It looks like there is a sensitivity setting under Windows settings app. Could this perhaps be used to set these settings?

larryqiann avatar Nov 27 '19 20:11 larryqiann

+1 for this issue. Mayby, because of that i often get cursor "shake"

Here is short video with demostration: https://puu.sh/EY0jZ/2f1166eb5a.mp4

reznikartem avatar Jan 09 '20 14:01 reznikartem

@larryqiann

It looks like there is a sensitivity setting under Windows settings app. Could this perhaps be used to set these settings?

I don't think it's the same as settings on Windows level influence all touchpads in the system (and I'm using laptop, so have an extra one that is build in) It must be something on the device level.

tyger avatar Jan 09 '20 15:01 tyger

@reznikartem

+1 for this issue. Mayby, because of that i often get cursor "shake"

Here is short video with demostration: https://puu.sh/EY0jZ/2f1166eb5a.mp4

Yes, that looks like something that I experience some time as well.

tyger avatar Jan 09 '20 15:01 tyger

Same issue. Any idea about changing the threshold? Maybe we can modify the source code and compile it manually before the tools release.

evi0s avatar Apr 24 '20 03:04 evi0s

I also have the exactly same issue. Changing the sensitivity value in Windows setting did not affect this issue at all. Any other solutions?

taterujp avatar May 01 '20 01:05 taterujp

I also tried the Magic Utilities then the sensitivity was ok with it. However some important behavior are not supported (dragging by tap-hold-move, dragging by 1stfingerclick-2ndfingertapholdmove, horizontal scroll on Excel and other apps, etc) and it isn’t enough for me to use. Again, is there any way to change this sensitivity?

taterujp avatar May 07 '20 02:05 taterujp

I also tried the Magic Utilities then the sensitivity was ok with it. However some important behavior are not supported (dragging by tap-hold-move, dragging by 1stfingerclick-2ndfingertapholdmove, horizontal scroll on Excel and other apps, etc) and it isn’t enough for me to use. Again, is there any way to change this sensitivity?

It seems to only happen with this specific precision driver. If you disconnect from it and use it with the native bluetooth or native USB support without the driver this issue does not happen. With touchpad++ driver and with the other paid driver it does not happen. Only with the Precision driver does it specifically happen. Makes it a bit unstable overall for daily use. Hopefully a fix isn't that far away.

omegamalkior avatar Jul 12 '20 21:07 omegamalkior

Yes, as Evi0s mentioned above, since this has gone a long time without a fix, maybe you could let us know which line has the value so we could adjust/recompile manually for the time being?

joeholley avatar Aug 14 '20 01:08 joeholley

Would love a fix for this as well. Coming up on a year with no fix now. The driver is fantastic in every other way but this hyper sensitivity can be frustrating.

michaelgosling avatar Oct 29 '20 12:10 michaelgosling

@imbushuo Any updates or timeline for providing a way to adjust the threshold? This is still a major issue, and prevents me from using it or promoting this driver to others. For me it's overly sensitive, and the cursor moves easily without even physically touching the surface.

funky-jojo avatar Jun 02 '21 13:06 funky-jojo

Yes, as Evi0s mentioned above, since this has gone a long time without a fix, maybe you could let us know which line has the value so we could adjust/recompile manually for the time being?

https://github.com/imbushuo/mac-precision-touchpad/blob/734b084b365b6168234049a8a61e569ae5ab19ca/src/AmtPtpHidFilter/include/Metadata/MagicTrackpad2.h#L8

https://github.com/imbushuo/mac-precision-touchpad/blob/734b084b365b6168234049a8a61e569ae5ab19ca/src/AmtPtpHidFilter/include/Metadata/MagicTrackpad2.h#L49

It's probably these two lines that affect it. Good luck if you try to compile it!

duckyb avatar Sep 07 '21 23:09 duckyb

@duckyb Not really that line, there was two hardcoded threshold things in HID Input.c:

Check how tip switch bit and confidence bit is reported, and currently it's hardcoded. On high level I just need to make these two values configurable.

imbushuo avatar Sep 07 '21 23:09 imbushuo

Check how tip switch bit and confidence bit is reported, and currently it's hardcoded. On high level I just need to make these two values configurable.

@imbushuo Please do!!! I would definitely donate to this effort. I would pay good money for a version of this driver if usable on day-to-day basis.

funky-jojo avatar Sep 07 '21 23:09 funky-jojo

@imbushuo Thank you for the correction, so it's this one?

https://github.com/imbushuo/mac-precision-touchpad/blob/dd364d6c432bb2b1119c966046044e4068802ed4/src/AmtPtpHidFilter/Input.c#L214-L217

@funky-jojo I'd love to help but I don't have the required skills to do this, unfortunately. I've never programmed in C or made drivers before.

duckyb avatar Sep 07 '21 23:09 duckyb

@duckyb Yes.

imbushuo avatar Sep 07 '21 23:09 imbushuo

To anyone interested - I just submitted a PR that I believe would fix this issue:

https://github.com/imbushuo/mac-precision-touchpad/pull/436

I tested it out and it works perfectly, at least on my Magic Trackpad 2. Building it is a bit of a pain so hopefully we can get an official release here soon. 🤞

b0undl3ss avatar Sep 26 '21 00:09 b0undl3ss

bump

mmikeww avatar May 10 '23 07:05 mmikeww

bump

fhardillah avatar Sep 26 '23 12:09 fhardillah

bump

philipwindeyer avatar Mar 27 '24 23:03 philipwindeyer