Ponnapalli Bhargav comments

Results 68 comments of


                                            Ponnapalli Bhargav

[Suggestion] useFullscreen

> onChange and onError callbacks are also not something strictly necessary, but I would leave them for completeness sake (eg. browser might not support promises in Fullscreen API and one...

[Suggestion] useFullscreen

Let's go! @sszczep 🔥🔥

feat: useClickAndHold hook

@jefersonvinicius Awesome hook! Could you explain more about what this hook can do here for context as I review it?

feat: useClickAndHold hook

Hi @jefersonvinicius . Very sorry for being slow to respond. Totally my fault. Will get to this in the weekend!

Cancel any pending function calls when unmount

@Yukimotochern This looks awesome. Could I ask you to add a test case for this? That would be awesome! Thanks! 🙏🏽

Cancel any pending function calls when unmount

@Yukimotochern Sounds good! I will get this merge once I get someone to review this. cc @qqpann .

Cancel any pending function calls when unmount

Closing as I have moved your commits to #1302

add eject command

Hi @kentcdodds. I want to take this one up. How do I go about finishing it? Any gotchas?

add eject command

So, I will just probably try and reverse the init feature. Will send a PR soon.

add eject command

@kentcdodds Made good progress. Working on fixtures right now. Thanks!