slimmage icon indicating copy to clipboard operation
slimmage copied to clipboard

Slimmage Background Image plugin

Open protherj opened this issue 9 years ago • 8 comments

This is my first attempt at a Background Images plugin based on the Pull Request #37 from dancek. Slimmage has changed considerably and I hope I got it generally right.

Note: see the thread for Pull Request #55 for more background.

protherj avatar Nov 06 '15 18:11 protherj

How do I fix the Travis CI build issues?

protherj avatar Nov 06 '15 18:11 protherj

Looks like performance issues, if I interpret the log correctly (red timings), or am I wrong?

erikbra avatar Nov 12 '15 21:11 erikbra

First we need to fix the existing problems. Then we can address this PR by adding associated tests for the new functionality.

lilith avatar Nov 12 '15 22:11 lilith

@nathanaeljones whats the status of this pr?

wiedikerli avatar Jan 22 '16 10:01 wiedikerli

This is working great for me so far - thanks Jason. The only issue of slight concern is the lack of fallback like we have with

ProNotion avatar Mar 17 '16 10:03 ProNotion

@nathanaeljones any plans to merge this pr?

wiedikerli avatar Sep 22 '16 13:09 wiedikerli

@nathanaeljones I'd like to see this PR as part of the plugin also

firthy avatar Sep 22 '16 14:09 firthy

Slimmage.js tries to do a very difficult thing. 99% of possible techniques fail on at least 1 crucial browser. This is not a space where I can merge pull requests for features which don't have associated unit tests. The chance of any new feature working across the same set of browsers is miniscule, in general.

I can't merge this without tests, and I don't have the resources to fix the bitrot in the existing tests. If someone wants to tackle #58, I hand out write access quite readily. Once #58 is fixed, then tests can be added to this PR and (if they pass), it can be merged.

lilith avatar Sep 22 '16 20:09 lilith