octopress icon indicating copy to clipboard operation
octopress copied to clipboard

Allow version 2.0 (master) to use linenos, start and mark in code block

Open benedict-chan opened this issue 11 years ago • 10 comments
trafficstars

This is only for people who wants "start, mark" in the code block in 2.0 (master).

As I can't run branch 2.5 on my Windows machine.

As it looks like most of the development effort are now in 3.0, therefore I decided to merge only the corresponding plugins from 2.5 to master, I also updated the default theme as master doesn't support for line number.

Reference I used include Ricardos code: https://groups.google.com/d/msg/octopress/y1IlHmFYydQ/MCSBrDrL1XIJ

benedict-chan avatar Jan 29 '14 05:01 benedict-chan

:+1:

coderberry avatar Jan 31 '14 03:01 coderberry

Any updates on this? Can this be merged now?

arielelkin avatar Feb 15 '14 00:02 arielelkin

+1

Looking for this functionality as well.

vastbinderj avatar Mar 11 '14 20:03 vastbinderj

This LGTM. Might be nice to have as work on 3.0 is continued. What say you, @imathis?

parkr avatar Mar 12 '14 04:03 parkr

Yes please! I tried installing octopress 3.0 but am facing a roadblock due to some compilation errors which I can't figure out how to solve. It would be great to have codefence like features in 2.0 too.

kaushalmodi avatar Mar 12 '14 05:03 kaushalmodi

3.0 hasn't been publicly released yet, so there are still some problems with it.

parkr avatar Mar 12 '14 05:03 parkr

I was also confused by the lack of support for these features in master, since the documentation on the website (dated 2011) describes these features.

+1 for getting it merged

GregMefford avatar Jun 18 '14 03:06 GregMefford

Thanks for the PR, but this seems to include some changes which are unrelated to adding these features. I've separated out the code highlighting core to octopress/code-highlighter and right now I'm working on reintegrating that into the 2.0 release. If all goes well I'll have this fixed in the next day or two.

imathis avatar Jun 22 '14 03:06 imathis

Hey @imathis any updates?

arielelkin avatar Jul 21 '14 18:07 arielelkin

:+1:

glittershark avatar Aug 04 '14 18:08 glittershark