Iván Martínez comments

Results 93 comments of


                                            Iván Martínez

Add new documents to an existing chroma collection

Closing in favor of #287

Rename example.env to example.env jvm arguments

What is the purpose of the PR?

Add script to update the database for adding more documents

#209 covers this functionality. But this PR has a very interesting approach to avoid ingesting the same document twice. Let's see if we can combine both. I'm inclined to add...

Require LangChain 0.0.171

Thanks for your comments! Requirements have been updated in https://github.com/imartinez/privateGPT/commit/1590c5890fb1c9aa63530fb3df0fe172e0b7b5e3 Closing this PR

Add script to update the database for adding more documents

@PulpCattel @maozdemir I updated the branch with main, applied the comments and merged it to main.

Update requirements.txt

Adopted this solution in https://github.com/imartinez/privateGPT/commit/1590c5890fb1c9aa63530fb3df0fe172e0b7b5e3 Closing this PR. Thanks a lot for your advise!

Make scripts executable, add basic pre-commit setup

Should we include `pre-commit` in requirements and update the Readme to explain how to use it (run `pre-commit install`)?

Make scripts executable, add basic pre-commit setup

> When it's mentionned, it's mentionned in a file such as "CONTRIBUTING.md" ([example](https://github.com/zigpy/zigpy/blob/a4300b171862bfdd561cedbdfd70ebd8dc251607/CONTRIBUTING.md?plain=1#L109-L117)). > > I can add such a file with an instruction just for that. We can leave...

Still can't install pypandoc-binary==1.11

Just updated requirements, should remove the issue. But if it keeps on failing in different OS, I'll just follow @mdeweerd advice and remove it from `requirements`

Con text

Closing this PR. Feel free to open a new one when you have a contribution ready. Thanks!