ffmpeg-dev-rs icon indicating copy to clipboard operation
ffmpeg-dev-rs copied to clipboard

Support optional x264 dependency

Open haileys opened this issue 4 years ago • 1 comments

This PR adds optional support for x264. It's disabled by default for licensing reasons, so users of this crate must opt in to x264 support by enabling the gpl and x264 features.

This pull request depends on the pkgconfig manifest PR over at https://github.com/imager-io/x264-dev/pull/1

haileys avatar May 01 '20 14:05 haileys

Interesting, initially when I wrote this library it was for the purpose of container muxing/demuxing and general decoding, and so in conjunction with keeping it self contained I never thought about supporting x264 for AVC encoding. Also seemed like I would be implementing the build stuff twice rather than use the x264 crate as you proposed.

Nice work :)

colbyn avatar May 03 '20 21:05 colbyn