pngquant-bin icon indicating copy to clipboard operation
pngquant-bin copied to clipboard

Remove process.exit(1); for npm install.

Open abetwothree opened this issue 7 years ago • 3 comments

This line is causing many people to stop from being able to deploy. (see this issue https://github.com/imagemin/pngquant-bin/issues/78) Can this be changed to determine whether libpng-dev can be installed on the system and stop the process if it can be installed with a warning to the user to install libpng-dev, else just continue on installing npm packages? It seems that systems with a commad of apt-get have access to libpgn-dev.

This line is literally stopping the deployment of apps on systems where libpng-dev cannot be installed.

I am on CentOS and there is no libpng-dev package for that system.

Thank you!

abetwothree avatar Mar 18 '18 18:03 abetwothree

Yes. I am having the same issue. A warning to the user would be better than this exiting. And we cannot reference a lower version of this as well. As this is a dependency of a dependency of a dependency.

Changes to this would be much appreciated.

srinidhiprabandham avatar Mar 21 '18 07:03 srinidhiprabandham

Is anyone looking into this, or do we have to come up with our own solutions? It is difficult for our project as it is an inner dependency, which means I can't solve it from code alone without committing node-modules and altering some code in there. Any help would be greatly appreciated.

PHDorin avatar Mar 26 '18 15:03 PHDorin

Same problem. 6 months of this PR... Is a dead project? Any one know an alternative?

maturanomx avatar Sep 17 '18 18:09 maturanomx