imagekit-nodejs icon indicating copy to clipboard operation
imagekit-nodejs copied to clipboard

Incorrect URL being generated

Open ahnv opened this issue 6 months ago • 0 comments

Sample Code:

var imagekit = require("imagekit")

let imagekitClient = new imagekit({ publicKey: "does-no-matter", urlEndpoint: "http://ik.imagekit.io/pwliscd3n", privateKey: "aksnda" })

console.log(imagekitClient.url({
    urlEndpoint: "http://ik.imagekit.io/pwliscd3n",
    path: "/Stu's Design/test_YAWJ6NgGN.jpg",
    signed: false,
}))

Expected output https://ik.imagekit.io/pwliscd3n/Stu's%20Design/test_YAWJ6NgGN.jpg - This URL works

Actual output https://ik.imagekit.io/pwliscd3n/Stu%27s%20Design/test_YAWJ6NgGN.jpg - This does not work

We use url.format which is a legacy api, we should use the WHATWG URL API https://nodejs.org/api/url.html#urlformaturlobject

ahnv avatar Aug 16 '24 08:08 ahnv