imageio-ffmpeg icon indicating copy to clipboard operation
imageio-ffmpeg copied to clipboard

Add a null filter to re-enable frame count

Open tvercaut opened this issue 11 months ago • 1 comments

This aims at addressing https://github.com/imageio/imageio-ffmpeg/issues/99

tvercaut avatar Mar 07 '24 14:03 tvercaut

CI fails on one specific test: https://github.com/imageio/imageio-ffmpeg/blob/9ab981a8d09138fb1b3b814cb4287b705f258ec5/tests/test_io.py#L40-L43

The result is 14.0, so it fails. I confirmed (in #108) that without the change in this PR, this failure does not happen. So apparently ffmpeg produces a slightly different value, depending on these output args.

Nonetheless, I think its safe to just update theupper bound to <= 14.0 in this test.

almarklein avatar Mar 08 '24 08:03 almarklein

I can confirm this fix works for M1/M2 macbooks as well.

kkoomen avatar May 21 '24 06:05 kkoomen

@tvercaut could you update the test I referenced in my earlier comment? That should make the tests pass, so we can merge this 🚀

almarklein avatar May 21 '24 07:05 almarklein

@almarklein can't you just update the tests? Looks like OP isn't that active.

kkoomen avatar May 22 '24 12:05 kkoomen

I just pushed the requested test relaxation change for the PR.

tvercaut avatar May 23 '24 07:05 tvercaut

@almarklein can you publish a new version pypi version?

kkoomen avatar May 31 '24 08:05 kkoomen

done!

almarklein avatar May 31 '24 19:05 almarklein