jpeg-decoder icon indicating copy to clipboard operation
jpeg-decoder copied to clipboard

fix clippy warnings and clean some code

Open lovasoa opened this issue 6 years ago • 4 comments

Hello! I started fixing the numerous clippy warnings inside jpeg-decoder. They improve the source readability, and sometimes performance. The work is not done, but if you want to help, you have push access to this branch :)

lovasoa avatar Aug 26 '19 16:08 lovasoa

@kaksmet : I think this is ready for merging. Can you have a look at the changes ? Most are trivial, mainly using as for lossless type conversions. The only semi-significant changes are to Decoder::decode_scan: this is a 160 line long function that I tried to break down in the process of fixing a too many arguments clippy warning. I am ready to make changes if needed.

lovasoa avatar Aug 29 '19 09:08 lovasoa

@kaksmet : do you think you will have the time to review that? Do you need help maintaining this library?

lovasoa avatar Sep 10 '19 21:09 lovasoa

@kaj: Thank you for the review. However, since @kaksmet does not seem to be answering to issues and PR anymore, I'm not going to invest time into splitting this into several PRs.

lovasoa avatar Sep 18 '19 14:09 lovasoa

If anyone is still interested in this PR, I can give you access to my fork. I checked Allow edits from maintainers, so all maintainers should already have commit rights.

lovasoa avatar Nov 10 '19 21:11 lovasoa

Is this PR still valid? Otherwise, I might create new one with Clippy/fmt fixes.

taavit avatar Apr 27 '23 18:04 taavit

This PR has accumulated years of merge conflicts, so you're probably much better off starting a new PR.

(Please do heed the advice above about making small PRs: it is way easier to merge something if you can just eyeball and see it won't break anything!)

fintelia avatar Apr 28 '23 03:04 fintelia