imageproc icon indicating copy to clipboard operation
imageproc copied to clipboard
verified publisher icon image-rs

Switch from quickcheck to proptest

Open ripytide opened this issue 1 year ago • 5 comments

Fixes #626

ripytide avatar Jun 24 '24 16:06 ripytide

You didn't disable miri on proptests

cospectrum avatar Jun 27 '24 08:06 cospectrum

You can move them to local mod proptests

cospectrum avatar Jun 27 '24 08:06 cospectrum

Some utility functions were used in both normal tests and protests so I found it easier to just leave them together, but I suppose the best solution would be to add another shared utils module.

ripytide avatar Jun 27 '24 08:06 ripytide

You can make some helpers from mod tests public

cospectrum avatar Jun 27 '24 10:06 cospectrum

Okay I've extracted all proptests into their own proptest modules which is definitely much nicer. Thanks @cospectrum for the pointer on making testing utilities pub.

ripytide avatar Jun 28 '24 19:06 ripytide

Lgtm

cospectrum avatar Jul 05 '24 08:07 cospectrum

A nice improvement, thanks. I’ll merge after the version issue is resolved.

theotherphil avatar Aug 15 '24 04:08 theotherphil

It's because of dependencies, need to restart the job somehow. MSRV was increased in another PR

cospectrum avatar Aug 15 '24 09:08 cospectrum

Details -> rerun, probably

cospectrum avatar Aug 15 '24 10:08 cospectrum

Thanks!

theotherphil avatar Aug 18 '24 06:08 theotherphil