image icon indicating copy to clipboard operation
image copied to clipboard

fix #1733

Open silentbat opened this issue 3 years ago • 2 comments

fixes #1733

but to be totally honest with you - I do not really understand it. How does skipping x_delta pixels help to get to the correct x position? I thought we need the current x position + x_delta for this??

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

silentbat avatar Jun 21 '22 15:06 silentbat

Honest, I'm just delaying here because I don't get it either :slightly_frowning_face: It all seems like action at a distance how all the variables work together.

197g avatar Jul 07 '22 20:07 197g

That is totally fine, I have something in the working - but currently I am only able to do it working directly on the pixelbuffer, not using the nice iterator patterns.

The "fix" above is just fixing it for some specific cases sadly. (It fixes the combination of "newline" + "delta jump", but not when there are multiple jumps needed because the real jump would be more far away than the possible 255 pixels)

silentbat avatar Jul 18 '22 19:07 silentbat

I'm going to close this for now. It seems too likely to cause regressions given that we don't have a good understanding of what's going on. If someone wants to figure out how the code is supposed to work, please feel free to open a new PR

fintelia avatar Feb 19 '23 23:02 fintelia