image icon indicating copy to clipboard operation
image copied to clipboard
verified publisher icon image-rs

Tracking: imageops:: and DynImage::crop()/crop_imm() breakage

Open nabijaczleweli opened this issue 5 years ago • 2 comments

Previously: https://github.com/image-rs/image/pull/1200#discussion_r409827806

  1. imageops::crop() is to be renamed to crop_mut(), and imageops::crop_imm() to crop()
  2. DynImage::crop()'s signature is to be replaced with crop_imm()'s, and crop_imm() removed

nabijaczleweli avatar Apr 17 '20 00:04 nabijaczleweli

Just noticed that docs of DynamicImage::crop says the signature will be replaced in 0.24 release, but looks like that never happened even though 0.24 was released some time ago? Should the docs be updated? @HeroicKatora

RReverser avatar Sep 10 '23 21:09 RReverser

Yeah, probably should update the docs. Though if anyone is interested in making a PR, we can make note of it in #1943 to make sure they don't get forgotten when we are making the 0.25 release

fintelia avatar Nov 13 '23 05:11 fintelia