image-png icon indicating copy to clipboard operation
image-png copied to clipboard
verified publisher icon image-rs

StoredOnlyCompressor feature is here, and we can now access it.

Open arichnad opened this issue 1 year ago • 2 comments

StoredOnlyCompressor feature is here, and we can now access it:

Why

Creating a png with Compression::None makes file creation much faster than Compression::Fast.

For hard to compress images, file size between Compression::None and Compression::Fast is is similar.

arichnad avatar Jul 29 '24 05:07 arichnad

I've addressed one of your comments and rebased onto master. Thanks @fintelia and @HeroicKatora !

arichnad avatar Sep 18 '24 14:09 arichnad

Looks good. We'll just want to hold off merging until we've gotten out a minor release with all the non-breaking changes we want to land

fintelia avatar Sep 19 '24 05:09 fintelia

This has been implemented as Compression::NoCompression variant in #503, which is now merged, so I'm going to go ahead and close this PR.

Despite this exact PR not getting merged, it has informed #503 significantly and the NoCompression option would not have been included without this PR. So thank you!

Shnatsel avatar Jan 12 '25 04:01 Shnatsel

Thank you, @Shnatsel !

arichnad avatar Jan 17 '25 15:01 arichnad