CoordinatorKit

CoordinatorKit copied to clipboard

Fix memory leak

2

When the new module is being set as the root, the old modules are not being deallocated

ghost

presentAuthFlow memory leak

1

Hey Callum, when the AuthCoordinator is presented it's also possible to dismiss the coordinator by swiping down, in this case, the coordinator.onCancel() closure doesn't get called and so the coordinator...

eduhh94

Memory leak when setting navigation controller delegate on view controller.

2

Like with all the other examples and yours, setting the view controller as the delegate to the navigation controller delegate property breaks your closure link responsible for deallocating the child...

pavankataria

I have different items in Flyout (hamburger) menu in the app. How to make this pattern work in such a case ? Can you share an example ?

nitishmaropost

Hi there, thanks for the implementation. I think, `setRootModule` method should clear completions dictionary, otherwise it will keep all added viewControllers into it from deallocating.

daurenm

Proposal: TabBarCoordinaators and SplitViewCoordinators itself can also be seen as a Router, maybe we should think of Router as a feature of coordinators. Actually any kind of Coorindator could act...

MiMo42