Juuso Alasuutari

icon indicating an email [email protected]

icon location Finland icon location Strong eye for bugs; pedantic background in C. In love with C23, on friendly terms with C++20 and later. Unix beard territory.

Results 44 comments of Juuso Alasuutari

Fix Undefined Behavior by replacing illegal overlap test with memmove()

@DaveGamble are you busy with life these days? It's understandable. But it would be nice to see cJSON improve, too.

v1.7.19 added Undefined Behavior to cJSON_SetValuestring()

The fix is to just not bother with the janky comparison logic and use `memmove()` instead of `strcpy()`. Overlapping strings are not a problem after that. You already take the...

v1.7.19 added Undefined Behavior to cJSON_SetValuestring()

Bumping this to mention that #924 fixes the UB.

v1.7.19 added Undefined Behavior to cJSON_SetValuestring()

Again, that string overlap comparison is **Undefined Behavior**. It's not legal C.