fl_chart icon indicating copy to clipboard operation
fl_chart copied to clipboard

Add ability to use ExtraLinesData in the BarChartData

Open NikitaPipita opened this issue 2 years ago • 3 comments

Resolves issue #476

  • Moved ExtraLinesData class and related classes from line_chart_data.dart to axis_chart_data.dart;
  • Moved drawExtraLines function from LineChartPainter class to AxisChartPainter class;
  • Added extraLinesData variable to AxisChartData and BarChartData constructors.

NikitaPipita avatar Apr 15 '22 17:04 NikitaPipita

Codecov Report

Merging #975 (5222d1a) into master (544ad7a) will decrease coverage by 0.01%. The diff coverage is 36.66%.

@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
- Coverage   85.02%   85.00%   -0.02%     
==========================================
  Files          42       42              
  Lines        2717     2721       +4     
==========================================
+ Hits         2310     2313       +3     
- Misses        407      408       +1     
Impacted Files Coverage Δ
.../src/chart/base/axis_chart/axis_chart_painter.dart 67.81% <34.52%> (-31.08%) :arrow_down:
lib/src/chart/line_chart/line_chart_painter.dart 90.74% <50.00%> (+8.12%) :arrow_up:
lib/src/chart/bar_chart/bar_chart_painter.dart 93.61% <75.00%> (-0.27%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Apr 20 '22 19:04 codecov[bot]

Waiting for this update

FriendlyNeighbor avatar May 24 '22 23:05 FriendlyNeighbor

Hi. Please resolve conflicts and update your branch. Then I will review it ASAP.

imaNNeo avatar Jun 10 '22 18:06 imaNNeo

Hi! any updates when this will be merged?

santiracca avatar Nov 29 '22 17:11 santiracca

Any reason this PR was closed? I could use this feature on charts I am creating. Perhaps I or someone else can continue this if we know why it was closed?

JoshMart avatar Jan 15 '23 23:01 JoshMart

I closed this PR because the contributor is not responsive.

imaNNeo avatar Jan 16 '23 09:01 imaNNeo

Thanks. I've picked up this work in a fork using these PRs as a starting point, for anyone interested.

JoshMart avatar Jan 16 '23 20:01 JoshMart

It would be great if you mention this PR in your new PR. Thanks

imaNNeo avatar Jan 16 '23 21:01 imaNNeo