fl_chart icon indicating copy to clipboard operation
fl_chart copied to clipboard

I need BarChart & Linechart's extraLinesData

Open jpoh281 opened this issue 4 years ago • 10 comments

image + image

and I use barchart in SingleChildScrollview. How can I adjust width interver ?

jpoh281 avatar Oct 21 '20 08:10 jpoh281

Sorry I didn't understand!

imaNNeo avatar Oct 23 '20 14:10 imaNNeo

I understand this package, bar chart can't extraLines. but I want draw extraLine

jpoh281 avatar Oct 23 '20 18:10 jpoh281

Aha got it.

imaNNeo avatar Oct 24 '20 08:10 imaNNeo

Screenshot 2020-11-10 at 15 18 04 I think I have the same problem. We need a dashed horizontal line to show the average.

If you are planning to add this feature, may I ask in how long I could expect it? As I need to know whether I should think of some Stack workaround or I should just wait a bit.

Thanks for the great work anyway!

matbujnowicz avatar Nov 10 '20 15:11 matbujnowicz

I understand you need it. But keep in mind that I have my personal life and I have to spend time on my personal stuff. I have a little time for maintaining this repo or something like that. Donation motivates me to work more here (as you know everyone needs to make money somehow). Also, I suggest you make your hands dirty and read the source code. Then you can make your merge request. Thanks, regards!

imaNNeo avatar Nov 10 '20 18:11 imaNNeo

I've started looking at the code to add this feature, tackling this as my first-ever contribution to OSS. The ExtraLinesData class is defined in line_chart_data.dart . We can reuse this class for the BarChart as well. Just want to find out whether I leave the class in that file, because my gut feel is that it should move to a more generic file. I'm just not sure where to move it to

DooRooSA avatar Apr 10 '22 11:04 DooRooSA

I've started looking at the code to add this feature, tackling this as my first-ever contribution to OSS. The ExtraLinesData class is defined in line_chart_data.dart . We can reuse this class for the BarChart as well. Just want to find out whether I leave the class in that file, because my gut feel is that it should move to a more generic file. I'm just not sure where to move it to

Hi @DooRooSA. Sorry for my late answer. I'm very happy that you are trying to do your first-ever contribution. It seems someone else created a PR for this. But it doesn't mean that you cannot implement it in your way. I will merge a branch that will be ready faster. Or maybe you can try on another issue.

imaNNeo avatar Apr 20 '22 19:04 imaNNeo

hi @imaNNeoFighT,

No worries, if it's been done already, it'll be better if I carry on with something else. Have a great day!

DooRooSA avatar Apr 21 '22 07:04 DooRooSA

Have a great day!

imaNNeo avatar Apr 21 '22 16:04 imaNNeo

was this successfully merged?

FriendlyNeighbor avatar May 24 '22 22:05 FriendlyNeighbor

It appears as if this has not been resolved yet. It would be very useful for me as well to draw mean and standard deviation horizontally on a bar chart.

JoshMart avatar Jan 15 '23 23:01 JoshMart

No. The PR contributor was not responsive and I just closed the PR. Now everyone can take this task and implement it.

imaNNeo avatar Jan 16 '23 10:01 imaNNeo

Thanks for the update. I am working on enabling this feature and using code from previous PRs as a starting point.

JoshMart avatar Jan 16 '23 20:01 JoshMart

This feature is added in 0.60.0. Check it out!

imaNNeo avatar Jan 26 '23 21:01 imaNNeo