add label inside bar chart
added text and text style for barchart in rodstackitem you can see it in sample 4 and 5
Hi Ali, Thanks for contributing! But there are some points to mention, please take a look:
Thanks a lot for your feedback. I fixed all problems that you mentioned
Perfect! Now I just see a conflict. Please rebase your branch and resolve it (It's about the code docs, as I see)
Also, please update the documentation in our bar_chart.md (as it is explained in our contribution guideline)
And the last thing. Please revert the changes on sample 4
But let's keep it in sample 5 with a minor change,
You can show the section if it is touched.
And we can have A, B, C, and D as they make more sense
(For your convenience, I provided this gist code for the sample5, I think you can just copy-paste)
https://github.com/user-attachments/assets/72ec7a49-4f8a-4fda-9681-1346577c491e
Thanks again. I fixed the problems. Is there anything else to fix ?
Perfect! Everything is good. Please rebase the branch, then I can merge it into the main. Thanks Ali!
I am really sorry. I had never used rebase I searched and did some work, but I don't know if it is fixed or not
Hi, can you please rebase your branch? There are some conflicts.
Please keep in mind that you don't have to touch CHANGELOG.md, example/pubspec.yaml and pubspec.yaml
I will manage those changes, just keep them unchanged please
it's done.
Hi,
Thanks for the PR !
I've noticed that the label is upside-down with rotationQuarterTurns to 1 or 3.
Hi, Thanks for the PR ! I've noticed that the label is upside-down with
rotationQuarterTurnsto 1 or 3.
Hi, can you please send me your code here
And after that comment, it's approved and ready to get merged! I'm sorry it took a long time. I appreciate your contribution, Ali!
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.48%. Comparing base (9e51b11) to head (d98c888).
:warning: Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1893 +/- ##
==========================================
+ Coverage 92.44% 92.48% +0.03%
==========================================
Files 50 50
Lines 3681 3700 +19
==========================================
+ Hits 3403 3422 +19
Misses 278 278
| Flag | Coverage Δ | |
|---|---|---|
| flutter | 92.48% <100.00%> (+0.03%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
There's a code verification issue I think you need to do a rebase to get rid of that.
It seems the test coverage has dropped. You should write unit test for all the new parts
I added unit test
Perfect! Thanks for your nice contribution!
