fl_chart icon indicating copy to clipboard operation
fl_chart copied to clipboard

add label inside bar chart

Open alikhavarii13 opened this issue 8 months ago • 6 comments

Screenshot (4)

added text and text style for barchart in rodstackitem you can see it in sample 4 and 5

alikhavarii13 avatar Apr 10 '25 10:04 alikhavarii13

Hi Ali, Thanks for contributing! But there are some points to mention, please take a look:

imaNNeo avatar Apr 28 '25 15:04 imaNNeo

Thanks a lot for your feedback. I fixed all problems that you mentioned

alikhavarii13 avatar May 03 '25 09:05 alikhavarii13

Perfect! Now I just see a conflict. Please rebase your branch and resolve it (It's about the code docs, as I see)

Also, please update the documentation in our bar_chart.md (as it is explained in our contribution guideline)

And the last thing. Please revert the changes on sample 4 image

But let's keep it in sample 5 with a minor change, You can show the section if it is touched. And we can have A, B, C, and D as they make more sense (For your convenience, I provided this gist code for the sample5, I think you can just copy-paste)

https://github.com/user-attachments/assets/72ec7a49-4f8a-4fda-9681-1346577c491e

imaNNeo avatar May 03 '25 21:05 imaNNeo

Thanks again. I fixed the problems. Is there anything else to fix ?

alikhavarii13 avatar May 08 '25 19:05 alikhavarii13

Perfect! Everything is good. Please rebase the branch, then I can merge it into the main. Thanks Ali!

imaNNeo avatar May 09 '25 17:05 imaNNeo

I am really sorry. I had never used rebase I searched and did some work, but I don't know if it is fixed or not

alikhavarii13 avatar May 09 '25 18:05 alikhavarii13

Hi, can you please rebase your branch? There are some conflicts. Please keep in mind that you don't have to touch CHANGELOG.md, example/pubspec.yaml and pubspec.yaml I will manage those changes, just keep them unchanged please

imaNNeo avatar Aug 01 '25 22:08 imaNNeo

it's done.

alikhavarii13 avatar Aug 13 '25 15:08 alikhavarii13

Hi, Thanks for the PR ! I've noticed that the label is upside-down with rotationQuarterTurns to 1 or 3. image

ad-angelo avatar Aug 14 '25 19:08 ad-angelo

Hi, Thanks for the PR ! I've noticed that the label is upside-down with rotationQuarterTurns to 1 or 3. image

Hi, can you please send me your code here

alikhavarii13 avatar Aug 20 '25 14:08 alikhavarii13

And after that comment, it's approved and ready to get merged! I'm sorry it took a long time. I appreciate your contribution, Ali!

imaNNeo avatar Aug 21 '25 10:08 imaNNeo

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.48%. Comparing base (9e51b11) to head (d98c888). :warning: Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
+ Coverage   92.44%   92.48%   +0.03%     
==========================================
  Files          50       50              
  Lines        3681     3700      +19     
==========================================
+ Hits         3403     3422      +19     
  Misses        278      278              
Flag Coverage Δ
flutter 92.48% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 21 '25 12:08 codecov[bot]

There's a code verification issue I think you need to do a rebase to get rid of that.

imaNNeo avatar Aug 21 '25 12:08 imaNNeo

It seems the test coverage has dropped. You should write unit test for all the new parts

imaNNeo avatar Aug 21 '25 15:08 imaNNeo

I added unit test

alikhavarii13 avatar Aug 23 '25 16:08 alikhavarii13

Perfect! Thanks for your nice contribution!

imaNNeo avatar Aug 24 '25 16:08 imaNNeo