fl_chart icon indicating copy to clipboard operation
fl_chart copied to clipboard

feat: add title to BarChartRodStackItem

Open ImagineBoom opened this issue 2 years ago • 4 comments

Closes #1371

ImagineBoom avatar Jun 20 '23 06:06 ImagineBoom

Codecov Report

Merging #1372 (cdbeb7c) into master (478e5e6) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head cdbeb7c differs from pull request most recent head 7aaaac3. Consider uploading reports for the commit 7aaaac3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   86.09%   86.08%   -0.01%     
==========================================
  Files          45       45              
  Lines        2978     2976       -2     
==========================================
- Hits         2564     2562       -2     
  Misses        414      414              

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 04 '23 23:07 codecov[bot]

It would be better if we keep a generic type of data (not only strings). For example, we can keep a dynamic type which could be anything

imaNNeo avatar Jul 04 '23 23:07 imaNNeo

It would be better if we keep a generic type of data (not only strings). For example, we can keep a dynamic type which could be anything

@imaNNeo Thank you😀, I have made the changes.

ImagineBoom avatar Jul 05 '23 05:07 ImagineBoom

title is not a good name anymore as it is a dynamic field. I suggest renaming it to something like payload or data. Also, you need to rebase your branch and write some unit tests for it (read our contributing guidelines carefully).

imaNNeo avatar Jul 31 '23 22:07 imaNNeo