feat: add title to BarChartRodStackItem
Closes #1371
Codecov Report
Merging #1372 (cdbeb7c) into master (478e5e6) will decrease coverage by
0.01%. The diff coverage isn/a.
:exclamation: Current head cdbeb7c differs from pull request most recent head 7aaaac3. Consider uploading reports for the commit 7aaaac3 to get more accurate results
@@ Coverage Diff @@
## master #1372 +/- ##
==========================================
- Coverage 86.09% 86.08% -0.01%
==========================================
Files 45 45
Lines 2978 2976 -2
==========================================
- Hits 2564 2562 -2
Misses 414 414
see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
It would be better if we keep a generic type of data (not only strings). For example, we can keep a dynamic type which could be anything
It would be better if we keep a generic type of data (not only strings). For example, we can keep a
dynamictype which could be anything
@imaNNeo Thank you😀, I have made the changes.
title is not a good name anymore as it is a dynamic field.
I suggest renaming it to something like payload or data.
Also, you need to rebase your branch and write some unit tests for it (read our contributing guidelines carefully).