cometblue icon indicating copy to clipboard operation
cometblue copied to clipboard

Published 20 hours ago • verified publisher icon im-0

Accept Pull Request

Open zapedge opened this issue 7 years ago • 5 comments

Hey,

it would be nice if you could accept the Pull request https://github.com/im-0/cometblue/pull/6

I want to use your tool to implement cometblue into the homeassitant home automation hub, but it needs to be python3 and available via pip. @xrucka did a great job so far porting your tool to python3. please consider to accept his changes.

greetings

zapedge avatar Feb 25 '18 10:02 zapedge

I would also appreciate a merge, because I was also not able to make the current version work. One or multiple dependencies/libraries could not be resolved.

RobsyRocket avatar Feb 25 '18 11:02 RobsyRocket

@zapedge I'm also about to integrate this into home-assistant. While this project seems unmaintained I started upon the fork from xrucka https://github.com/xrucka/cometblue . Maybe we can merge efforts?

mirko avatar Mar 18 '18 20:03 mirko

@RobsyRocket Hi, I get ambiguous reference for "current version" - do you mean mine, or im-0's?

@mirko @zapedge - I'm currently getting familiar with OpenHab internals and slowly moving towards getting support for this regulator in https://github.com/sputnikdev/eclipse-smarthome-bluetooth-binding/ , yet I have too little time to do it :-/. (fyi)

xrucka avatar Mar 18 '18 20:03 xrucka

I'm pretty confident I'll have a first version to test for home-assistant this week.

mirko avatar Mar 18 '18 22:03 mirko

Here we go: https://github.com/mirko/home-assistant/blob/cometblue/homeassistant/components/climate/cometblue.py

mirko avatar Mar 21 '18 21:03 mirko