cleanenv icon indicating copy to clipboard operation
cleanenv copied to clipboard

Update library used for toml support

Open cebarks opened this issue 4 years ago • 2 comments

The currently used toml library (github.com/BurntSushi/toml) has officially been marked as unmaintained by its owner. As such, it might be wise to move to a new library (support for newer versions of the TOML spec as burntsushi/toml only supports v0.4.0, bug/security fixes, etc).

cebarks avatar Nov 18 '20 23:11 cebarks

Codecov Report

Merging #63 (00988e1) into master (ce3ee7f) will decrease coverage by 0.68%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   89.79%   89.11%   -0.69%     
==========================================
  Files           1        1              
  Lines         245      248       +3     
==========================================
+ Hits          220      221       +1     
- Misses         17       18       +1     
- Partials        8        9       +1     
Impacted Files Coverage Δ
cleanenv.go 89.11% <50.00%> (-0.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce3ee7f...00988e1. Read the comment docs.

codecov[bot] avatar Nov 19 '20 01:11 codecov[bot]

Realized i never mentioned the new library this switches to is: https://github.com/pelletier/go-toml

cebarks avatar Nov 23 '20 08:11 cebarks

Closed since we already use the new github.com/BurntSushi/[email protected].

Maybe we will switch to go-toml in the future, but now I see no reason to do so.

ilyakaznacheev avatar Oct 17 '22 07:10 ilyakaznacheev