java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

ENHANCEMENT: bump junit.version from 5.11.4 to 5.12.2 + clean up

Open e5LA opened this issue 8 months ago • 6 comments

Pull Request Template

What does this PR do?

  1. Upgrading JUnit to version 5.12.2.
  2. Replacing individual dependencies (junit-jupiter-engine and junit-jupiter-params) with the junit-jupiter aggregator package https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter
  3. Moving mockito-junit-jupiter dependency to the parent pom.xml as it was previously declared with explicit versions in some modules. Also, excluding junit-jupiter-api from this dependency since the latest mockito-junit-jupiter version includes older version of junit-jupiter-api, which was causing test failures.
  4. Refactoring SimpleFileWriterTest to be compatible with JUnit 5.

Fixes https://github.com/iluwatar/java-design-patterns/pull/3259

e5LA avatar Apr 30 '25 12:04 e5LA

Analyzing changes in this PR...

This might take a few minutes, please wait

📥 Commits

Analyzing changes from base (8a64f4c) to latest commit (afe3910):

  • afe3910: refactor: using junit 5 in the test
  • eb70db2: build: moving mockito-junit-jupiter to dependencyManagement
  • b684cc7: build: adding junit dependency to the module
  • 445b395: build: using junit aggregator
  • 04a66d9: build: bump junit.version from 5.11.4 to 5.12.2 + using junit aggregator
📁 Files being considered (30)

🔄 abstract-document/pom.xml (1 hunk) 🔄 abstract-factory/pom.xml (1 hunk) 🔄 active-object/pom.xml (1 hunk) 🔄 actor-model/pom.xml (1 hunk) 🔄 acyclic-visitor/pom.xml (1 hunk) 🔄 adapter/pom.xml (1 hunk) 🔄 ambassador/pom.xml (1 hunk) 🔄 anti-corruption-layer/pom.xml (1 hunk) 🔄 arrange-act-assert/pom.xml (1 hunk) 🔄 async-method-invocation/pom.xml (1 hunk) 🔄 backpressure/pom.xml (1 hunk) 🔄 balking/pom.xml (1 hunk) 🔄 bloc/pom.xml (1 hunk) 🔄 bridge/pom.xml (1 hunk) 🔄 builder/pom.xml (1 hunk) 🔄 business-delegate/pom.xml (1 hunk) 🔄 bytecode/pom.xml (1 hunk) 🔄 caching/pom.xml (1 hunk) 🔄 callback/pom.xml (1 hunk) 🔄 chain-of-responsibility/pom.xml (1 hunk) 🔄 circuit-breaker/pom.xml (1 hunk) 🔄 clean-architecture/pom.xml (1 hunk) 🔄 client-session/pom.xml (1 hunk) 🔄 collecting-parameter/pom.xml (1 hunk) 🔄 collection-pipeline/pom.xml (1 hunk) 🔄 combinator/pom.xml (1 hunk) 🔄 command-query-responsibility-segregation/pom.xml (1 hunk) 🔄 command/pom.xml (1 hunk) 🔄 commander/pom.xml (1 hunk) 🔄 component/pom.xml (1 hunk)


autogenerated by presubmit.ai

github-actions[bot] avatar Apr 30 '25 12:04 github-actions[bot]

hi @iluwatar, I'm not sure how Presubmit.ai determines the PR type. I've updated the PR title - would re-triggering the job resolve the issue, or should I update the commit messages instead?

e5LA avatar May 01 '25 10:05 e5LA

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Jul 01 '25 02:07 github-actions[bot]

Its pending review

e5LA avatar Jul 01 '25 04:07 e5LA

This PR is stale because it has been open 60 days with no activity.

github-actions[bot] avatar Sep 20 '25 02:09 github-actions[bot]