java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard
verified publisher icon iluwatar

#1316 Single Table Inheritance pattern implemented

Open ved-asole opened this issue 2 years ago • 12 comments

Pull request title

  • Added the example for the Single Table Inheritance pattern under the PR #1316

Pull request description

  • Added the example for the Single Table Inheritance pattern under the PR #1316

For detailed contributing instructions see https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

ved-asole avatar Oct 10 '23 15:10 ved-asole

Hi @iluwatar, the code is running in my system but not sure why it is not working with the checks.. Could you please assist me to resolve this issue?

image

ved-asole avatar Oct 10 '23 16:10 ved-asole

Hi @iluwatar, could you please check and confirm if any changes are required?

ved-asole avatar Oct 10 '23 19:10 ved-asole

Hi @iluwatar, could you please review the above pull request

ved-asole avatar Oct 15 '23 09:10 ved-asole

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

3.4% 3.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

sonarqubecloud[bot] avatar Oct 26 '23 14:10 sonarqubecloud[bot]

Hi @iluwatar, I have updated the code as per the review. Please approve the merge request.

ved-asole avatar Oct 26 '23 14:10 ved-asole

Hi @iluwatar , I have updated the code as per the review. Please approve the merge request.

ved-asole avatar Oct 29 '23 19:10 ved-asole

Hi @iluwatar, please review the above PR. I have made the necessary changes after the review.

ved-asole avatar Nov 01 '23 20:11 ved-asole

Hi @iluwatar, could you please approve the change request?

ved-asole avatar Nov 13 '23 18:11 ved-asole

Hi @iluwatar , request you to please assist and approver the above PR

ved-asole avatar Nov 27 '23 15:11 ved-asole

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Dec 17 '23 09:12 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Jan 17 '24 17:01 stale[bot]

@iluwatar , could you please review and approve the PR?

ved-asole avatar Jan 17 '24 17:01 ved-asole

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 25 '24 21:01 sonarqubecloud[bot]

Hi @iluwatar , please approve the PR. I have resolved the merge conflicts

ved-asole avatar Jan 25 '24 21:01 ved-asole

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Feb 24 '24 22:02 stale[bot]

Looks good! Thank you for the contribution 🎉

@all-contributors please add @ved-asole for code

iluwatar avatar Feb 25 '24 12:02 iluwatar

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions? Please make sure to use valid contribution names.

I've put up a pull request to add @ved-asole! :tada:

allcontributors[bot] avatar Feb 25 '24 12:02 allcontributors[bot]