java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

Executable jar problem

Open iluwatar opened this issue 10 months ago • 11 comments

The project includes Maven Assembly plugin to produce executable jars out of all the submodules (individual patterns). However, there currently seems to be a problem with the intended behaviour.

Steps to reproduce:

  1. At the project root build everything, i.e. mvn clean package -DskipTests=true
  2. Execute one of the produced jars, e.g. java -jar spatial-partition/target/spatial-partition-1.26.0-SNAPSHOT.jar

Expected behaviour

  • The spatial partition jar is executed and the pattern example runs without problems

Actual behavior

  • An error message no main manifest attribute, in spatial-partition/target/spatial-partition-1.26.0-SNAPSHOT.jar is printed

iluwatar avatar Aug 20 '23 07:08 iluwatar

Hello @iluwatar Can you give me chance to solve above issue ? If yes then I'm willing to contribute over here and want to help you to solve executable jar problem.

Thank you in advance

satyajitbhatt avatar Aug 21 '23 06:08 satyajitbhatt

Can I have a look here ?

Sujoydas001 avatar Sep 23 '23 14:09 Sujoydas001

@satyajitbhatt are you working on it?

iluwatar avatar Sep 24 '23 15:09 iluwatar

No, I am not.

On Sun, Sep 24, 2023, 8:49 PM Ilkka Seppälä @.***> wrote:

@satyajitbhatt https://github.com/satyajitbhatt are you working on it?

— Reply to this email directly, view it on GitHub https://github.com/iluwatar/java-design-patterns/issues/2565#issuecomment-1732595463, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQA37LBSGJBBQPEG7M7L453X4BFPXANCNFSM6AAAAAA3XDA7MQ . You are receiving this because you were mentioned.Message ID: @.***>

satyajitbhatt avatar Sep 24 '23 16:09 satyajitbhatt

@iluwatar I want to go through the issue and work upon it

Navneetsinghnegi avatar Sep 27 '23 06:09 Navneetsinghnegi

Hi @iluwatar here we have 2 approaches to solve this bug a) add the name of main class to the jar file b) create the jar file as an executable jar

BrijeshPatra avatar Sep 29 '23 10:09 BrijeshPatra

I am trying hard to contribute but getting an error Unable to access jarfile spatial-partition/target/spatial-partition-1.26.0-SNAPSHOT.jar. It would be helpful if you review it once and suggest me something better @iluwatar

BrijeshPatra avatar Sep 29 '23 10:09 BrijeshPatra

Bug

BrijeshPatra avatar Sep 29 '23 10:09 BrijeshPatra

Assigned to @Navneetsinghnegi

iluwatar avatar Oct 01 '23 07:10 iluwatar

I would Like to work on this issue.

Aniket-kumar404 avatar Oct 01 '23 21:10 Aniket-kumar404

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 30 '23 23:11 stale[bot]