java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

Wrong generic type for deques in command README

Open AddeusExMachina opened this issue 1 year ago • 3 comments

Hi, inside the README.md for the command pattern the Wizard class presents these two instance variables:

private final Deque<Command> undoStack = new LinkedList<>();
private final Deque<Command> redoStack = new LinkedList<>();

The generic type for these deques should be Runnable as it is in the Wizard class under src directory

AddeusExMachina avatar Jan 25 '23 14:01 AddeusExMachina

can you assign me this issue?

I am interest in solve this issue?

ghost avatar Jan 26 '23 16:01 ghost

I'm new to open-sourcing and I have no clue about what I should be doing. Can anyone guide me? I have basic knowledge of java
let me know in which way I can help you.

jaswanthg76 avatar Mar 25 '23 10:03 jaswanthg76

@jaswanthg76 https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

AddeusExMachina avatar Mar 25 '23 11:03 AddeusExMachina

Hey I can help in this issue, provide me the information of issue

vatsasiddhartha avatar Sep 09 '23 11:09 vatsasiddhartha

Hi @vatsasiddhartha, the problem has actually been solved and the fix has been merged

AddeusExMachina avatar Sep 09 '23 11:09 AddeusExMachina