java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

Published 20 hours ago • verified publisher icon iluwatar

#393 Added notification pattern

Open DateNolan opened this issue 2 years ago • 5 comments

Added the notification design pattern along with tests and readme. However unfortunately had some issues with getting the uml diagram to auto generate, would appreciate some help with that.

I would also like to mention that this code is similar but seperate to NatalieSty's implementation of the same pattern, we both adapted our code from the same source and as such I would like to acknowledge their contribution to this pattern.

DateNolan avatar Oct 21 '22 11:10 DateNolan

Looks good :)

vishhhhhhhh avatar Oct 21 '22 16:10 vishhhhhhhh

@iluwatar Resolved all feedback given!

DateNolan avatar Oct 29 '22 07:10 DateNolan

@iluwatar I believe I resolved the issue with versioning

DateNolan avatar Nov 06 '22 22:11 DateNolan

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

97.0% 97.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 14 '22 05:11 sonarqubecloud[bot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale[bot] avatar Dec 23 '22 19:12 stale[bot]

Closed due to inactivity. Thank you for your contributions.

stale[bot] avatar Feb 08 '23 00:02 stale[bot]

https://github.com/iluwatar/java-design-patterns/issues/393

iluwatar avatar Feb 18 '23 18:02 iluwatar