java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

DAO Factory pattern for Issue #1270

Open rrreynaldo opened this issue 2 years ago • 8 comments

Closes #1270

rrreynaldo avatar Oct 17 '22 12:10 rrreynaldo

Hi @iluwatar, this is the implementation for the DAO Factory based on the following resources and it is my first issue; kindly inform me if there is incorrect logic/concept or things which could be improved. Thanks a lot!

rrreynaldo avatar Oct 17 '22 12:10 rrreynaldo

Thank you, @rrreynaldo!

burno1 avatar Oct 17 '22 13:10 burno1

Hi @burno1, thanks for the review and I agree that enum would be a neater implementation. Just made the changes and Thanks a lot!

rrreynaldo avatar Oct 17 '22 13:10 rrreynaldo

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Oct 17 '22 14:10 sonarqubecloud[bot]

This closes https://github.com/iluwatar/java-design-patterns/issues/1270

burno1 avatar Oct 17 '22 17:10 burno1

@rrreynaldo, add the issue to the description of the PR, so we can have the two linked

burno1 avatar Oct 17 '22 17:10 burno1

@burno1 Done!

rrreynaldo avatar Oct 18 '22 00:10 rrreynaldo

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 23 '22 18:11 stale[bot]

Closed due to inactivity

iluwatar avatar Dec 01 '22 16:12 iluwatar