java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

Published 20 hours ago • verified publisher icon iluwatar

Refactor Prototype pattern (Closes #584)

Open yonatankarp opened this issue 3 years ago • 1 comments
trafficstars

This PR refactors the Prototype pattern by making it Cloneable and thus inheriting the clone() method to its subclasses which removes code duplications.

yonatankarp avatar Mar 02 '22 06:03 yonatankarp

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

75.0% 75.0% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Apr 20 '22 12:04 sonarqubecloud[bot]

This is a good refactoring that reduces the amount of boilerplate code. The code coverage is on a good level (75% on new code) even though Sonar is complaining.

iluwatar avatar Sep 08 '22 12:09 iluwatar

Thank you for the prototype pattern refactoring! 🎉

@all-contributors please add @yonatankarp for code

iluwatar avatar Sep 08 '22 12:09 iluwatar

@iluwatar

I've put up a pull request to add @yonatankarp! :tada:

allcontributors[bot] avatar Sep 08 '22 12:09 allcontributors[bot]